Remove XML tagging from org.dogtagpki.common #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edewata
reviewed
Jun 29, 2021
| @@ -90,7 +90,7 @@ public void execute(CommandLine cmd) throws Exception { | |||
| out.println(line); | |||
| } | |||
|
|
|||
| configData = ConfigData.fromXML(sw.toString()); | |||
| configData = ConfigData.fromJSON(sw.toString()); | |||
There was a problem hiding this comment.
This is going to change the input format for pki tps-config-modify --input <file>:
https://github.com/dogtagpki/pki/wiki/PKI-TPS-Configuration-CLI
@06shalini Is it OK if we change this CLI to take a JSON file instead of XML file?
There was a problem hiding this comment.
@ckelleyRH We'll need to move that page into the source repo so we can maintain different docs for different PKI versions. So PKI 10.11 will continue to use XML, but PKI 11.0 will use JSON.
There was a problem hiding this comment.
edewata
reviewed
Jun 29, 2021
| // converting Info object into XML | ||
| String xmlInfo = info.toXML(); | ||
| // converting Info object into JSON | ||
| String xmlInfo = info.toJSON(); |
ckelleyRH
force-pushed
the
xml_removal_common
branch
from
f307b2f to
66f2824
Compare
|
@edewata thanks! I'll wait for the approval on the other PR before merging. |
|
@ckelleyRH I'll merge both PRs. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.